Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard colors with non-white backgrounds #2911

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra requested a review from EDsCODE January 11, 2021 10:50
@timgl timgl temporarily deployed to posthog-fix-dashboard-c-ebynn0 January 11, 2021 10:52 Inactive
@mariusandra mariusandra temporarily deployed to posthog-fix-dashboard-c-ebynn0 January 11, 2021 11:46 Inactive
@mariusandra mariusandra temporarily deployed to posthog-fix-dashboard-c-ebynn0 January 11, 2021 11:47 Inactive
@mariusandra mariusandra temporarily deployed to posthog-fix-dashboard-c-ebynn0 January 11, 2021 12:46 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@@ -42,6 +42,7 @@ module.exports = {
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'no-shadow': 'warn',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants