-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show plugins in onboarding #4159
Conversation
Wellll, after reading https://github.com/PostHog/experiments/issues/2 I realized onboarding has been completely shut down as an experiment some time ago (even though it's still in code) – therefore #3764 seems to be outdated, and this PR in its current form is irrelevant. Should plugins end up in the new Project Home then - for instance? @kpthatsme @paolodamico |
So the onboarding experiment is shut down for now, but I do plan to re-scope it and bring back the setup page, so this is not wasted. We'll see how the project home evolves but I think that'll be more useful post-integration/post-setup. I can review this PR tomorrow or on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running this, but got this error:
Switching the listeners in personalizationLogic to lazily include organizationLogic (() => ({})
instead of {}
) fixed that.
Then, if I click this button
... twice! Then it consistently kills the tab
UX wise, I think we should just have a few checkboxes and then the "finish setup" button. I'm not sure the button to open plugins (and in a new tab) adds much. Let's instead have just one plugin there for now and add more later.
Other than that, looks good. If that crash gets fixed, I'd be Ok to merge.
Let's close this for now then... and reopen/recycle/regurgitate when there's a new place to put these toggles. |
Changes
This is a frontend-only change to onboarding section 2 UI, showing plugins. Builds on #4106, which made some plugins preinstalled and preenabled (currently only GeoIP, thinking about 1-3 more in the future).
Before
After
Checklist