Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy event_names code #4480

Merged
merged 8 commits into from
May 26, 2021
Merged

Remove legacy event_names code #4480

merged 8 commits into from
May 26, 2021

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented May 25, 2021

Changes

We're now exclusively using EventDefinition and PropertyDefinition. I want to make some changes to that but for #4166 but I want to refactor this first.

Note: this also removes volume stats for individual properties. I don't think they're as useful as events, and those queries are super expensive. It'll also allow me to do the next step, which will be to link properties to individual events, at which point you probably only need the event stats instead of both.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@timgl timgl requested a review from paolodamico May 25, 2021 16:24
@timgl timgl temporarily deployed to posthog-pr-4480 May 25, 2021 16:27 Inactive
@timgl timgl temporarily deployed to posthog-pr-4480 May 25, 2021 16:35 Inactive
@timgl timgl temporarily deployed to posthog-pr-4480 May 25, 2021 23:35 Inactive
@timgl timgl temporarily deployed to posthog-pr-4480 May 26, 2021 00:16 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! made a few tweaks and fixed tests

@timgl timgl temporarily deployed to posthog-pr-4480 May 26, 2021 00:36 Inactive
@paolodamico paolodamico merged commit 314d788 into master May 26, 2021
@paolodamico paolodamico deleted the remove-event_names branch May 26, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants