-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing in token to Personal API Key requests #5044
Conversation
Hey @yakkomajuri! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but: test needed :)
So that's the question - |
IMO good to just have this tested for a few more endpoints (since it's a global feature) |
Good to go, just documentation in posthog.com needed. |
Changes
Minimum possible change to address #4849.
With this change, when using personal API keys, you can specify a project to fetch data on by passing the project api key (token) as a query param.
Supporting changes needed:
#4764 introduced
_get_team_from_request
but only the feature flags queryset was updated to leverage this. Now all endpoints will have their queryset filtered by this team.Checklist