Allow Excluding Multiple Events + events in unordered funnels #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
commented
Jul 16, 2021
posthog/models/entity.py
Outdated
| @@ -89,6 +90,11 @@ class ExclusionEntity(Entity, FunnelFromToStepsMixin): | |||
| def __init__(self, data: Dict[str, Any]) -> None: | |||
| super().__init__(data) | |||
|
|
|||
| @property | |||
| def sql_id(self): | |||
| # TODO: prevent SQL injection :( | |||
There was a problem hiding this comment.
Probably just using a UUID here works.
Had other higher priority bugs to look into, will come back to this on Tuesday.
neilkakkar
changed the title
EDsCODE
reviewed
Jul 21, 2021
| to_time = f"event_times[{exclusion.funnel_to_step + 1}]" | ||
| exclusion_time = f"exclusion_{exclusion_id}_latest_{exclusion.funnel_from_step}" | ||
| condition = ( | ||
| f"if( {exclusion_time} > {from_time} AND {exclusion_time} < " |
There was a problem hiding this comment.
Is the "<" supposed to be trailing?
There was a problem hiding this comment.
multiple strings! These get concatenated automatically when enclosed in a paranthesis.
Felt clearer to me, about what's happening in the "<" (the next line)
neilkakkar
commented
Jul 22, 2021
EDsCODE
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until SQL injection issue is resolved~~To go after #5104 ~~
Fixes #5074
Changes
Event exclusion in unordered events
Support for multiple exclusions in the same step in ordered + unordered funnels
Checklist