Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show person modal actions for trends and stickiness #5297

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Only show person modal actions for trends and stickiness #5297

merged 2 commits into from
Jul 22, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 22, 2021

Changes

Please describe.

  • CSV and cohort creation support is limited to trends and stickiness at the moment
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@EDsCODE EDsCODE requested review from mariusandra and liyiy July 22, 2021 18:55
@timgl timgl temporarily deployed to posthog-pr-5297 July 22, 2021 18:56 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5297 July 22, 2021 19:29 Inactive
@liyiy liyiy enabled auto-merge (squash) July 22, 2021 19:33
@liyiy liyiy merged commit a9a1e21 into master Jul 22, 2021
@liyiy liyiy deleted the limit-person-modal-actions branch July 22, 2021 19:59
@liyiy liyiy mentioned this pull request Jul 22, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyiy liyiy liyiy approved these changes

@mariusandra mariusandra Awaiting requested review from mariusandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @liyiy @timgl