Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-spelling #41

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add check-spelling #41

merged 1 commit into from
Mar 24, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 22, 2023

This adds check-spelling, the workflow used to build #39.

As configured here, it's using the latest release (v0.0.21), without commenting enabled (reporting is view GitHub Step Summary) and without Sarif reporting.

It's always a good idea to review the basic expect.txt file to make sure there aren't any obvious typos that my initial pass didn't correct. If terms are permanent, they can be moved/promoted to allow.txt instead of remaining in expect.txt (see the advice.md file for some prose on this point).

advice.md is repository specific content that's included in reports, so please feel free to adjust it based on your repository's needs.

@Habbie Habbie self-requested a review March 24, 2023 07:38
jobs:
spelling:
name: Check Spelling
permissions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general suggestion, not just for here - add a comment (with references) that explains that you are -reducing- your permissions

@wojas wojas merged commit 7301592 into PowerDNS:main Mar 24, 2023
@wojas
Copy link
Member

wojas commented Mar 24, 2023

Merged, thanks!

@wojas wojas added this to the v0.3.1 milestone Mar 24, 2023
@jsoref jsoref deleted the spell-check branch March 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants