Fix race in syncer test #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojas
force-pushed
the
fix-test-data-race
branch
2 times, most recently
from
20c4eee to
17aa8cc
Compare
The test did not ensure that the previous Sync run was finished when
the next Sync run was started.
It was reproducible locally with:
GOMAXPROCS=1 go test -race -count=100 ./syncer | grep -A30 'DATA RACE'
Output:
WARNING: DATA RACE
Write at 0x00c000161e60 by goroutine 71:
runtime.mapassign_faststr()
/usr/local/Cellar/go/1.19.4/libexec/src/runtime/map_faststr.go:203 +0x0
powerdns.com/platform/lightningstream/syncer.(*Syncer).LoadOnce()
/Users/wojas/pdns/work-ls/lightningstream/syncer/sync.go:505 +0xc66
...
Previous read at 0x00c000161e60 by goroutine 64:
runtime.mapiterinit()
/usr/local/Cellar/go/1.19.4/libexec/src/runtime/map.go:815 +0x0
powerdns.com/platform/lightningstream/syncer/cleaner.(*Worker).SetCommitted()
/Users/wojas/pdns/work-ls/lightningstream/syncer/cleaner/cleaner.go:55 +0xee
...
wojas
force-pushed
the
fix-test-data-race
branch
from
17aa8cc to
f1d03ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test did not ensure that the previous Sync run was finished when the next Sync run was started.
It was reproducible locally with:
Output: