-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clear last line on Windows Terminal Issue again (#203). #207
Fix clear last line on Windows Terminal Issue again (#203). #207
Conversation
Marked as draft until Terminal.Gui v1.14.x gets released. |
src/Microsoft.PowerShell.ConsoleGuiTools/Microsoft.PowerShell.ConsoleGuiTools.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleGuiTools/Microsoft.PowerShell.ConsoleGuiTools.psd1
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleGuiTools/Microsoft.PowerShell.ConsoleGuiTools.psd1
Outdated
Show resolved
Hide resolved
@andyleejordan I think this is ready now. |
@tig reviewing now! Sorry, I was out sick for a while which pushed everything back on my schedule. |
Ok awesome, I built and tested locally and can't repro #203 with this, yay! However, when I tested with ![]() Is that a known issue with the .NET driver? I don't think I'm going to consider it a blocker since the default (with the Windows driver) worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working in default configuration. Looks like the spacing leftover when using -UseNetDriver
is a known issue in Terminal.GUI (based on following some other threads) so not blocking on that.
PR Summary
Terminal.Gui
lib version and support forcing NetDriver) #208-Debug
or-Verbose
parameters are set the OCGV status bar will display both theConsoleGuiTools
module version and theTerminal.Gui
library version.-UseNetDriver
parameter is set,Application.UseConsoleDriver
will be set to true, forcingTerminal.Gui
to useNetDriver
instead ofCursesDriver
(Linux) orWindowsDriver
(Windows).-Verbose
logging (Fixes Verbose output produces base64 encoded text #192)../Build.ps1
nowPSRepository
namedlocal
for local dev of downstream modulesPR Context
There are cases where the previous fix to #203 (#205) didn't work.
There are a lot of interactions between the platform (Windows v. Linux), terminal (e.g. Windows Terminal vs. VS Code's terminal), and Terminal.Gui's various drivers that conflict and are confusing. In addition, it's challenging to understand what code is actaully loaded when running a CmdLet. Hence the new diagnostics and ability to force NetDriver.
Note, with Terminal.Gui v2, the need for
-UseNetDriver
goes away because the new ConfigurationManager lets users set options like that globally, per-user, or on an app-by-app basis.