Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear last line on Windows Terminal Issue again (#203). #207

Merged
merged 18 commits into from
Oct 16, 2023

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 3, 2023

PR Summary

PR Context

There are cases where the previous fix to #203 (#205) didn't work.

There are a lot of interactions between the platform (Windows v. Linux), terminal (e.g. Windows Terminal vs. VS Code's terminal), and Terminal.Gui's various drivers that conflict and are confusing. In addition, it's challenging to understand what code is actaully loaded when running a CmdLet. Hence the new diagnostics and ability to force NetDriver.

Note, with Terminal.Gui v2, the need for -UseNetDriver goes away because the new ConfigurationManager lets users set options like that globally, per-user, or on an app-by-app basis.

@tig tig marked this pull request as draft August 6, 2023 10:11
@tig
Copy link
Collaborator Author

tig commented Aug 6, 2023

Marked as draft until Terminal.Gui v1.14.x gets released.

@tig tig marked this pull request as ready for review August 13, 2023 16:14
@tig tig requested a review from andyleejordan October 6, 2023 15:28
@tig
Copy link
Collaborator Author

tig commented Oct 6, 2023

@andyleejordan I think this is ready now.

@andyleejordan
Copy link
Member

@tig reviewing now! Sorry, I was out sick for a while which pushed everything back on my schedule.

@andyleejordan
Copy link
Member

Ok awesome, I built and tested locally and can't repro #203 with this, yay! However, when I tested with -UseNetDriver I ended up with a blank line that wouldn't go away:

image

Is that a known issue with the .NET driver? I don't think I'm going to consider it a blocker since the default (with the Windows driver) worked fine.

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working in default configuration. Looks like the spacing leftover when using -UseNetDriver is a known issue in Terminal.GUI (based on following some other threads) so not blocking on that.

@andyleejordan andyleejordan merged commit 4714dd4 into PowerShell:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants