-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting regression in 1.18.0 whereby single-line pipeline reduces indentation level incorrectly #1191
Conversation
…rrectly (problem only showed up when there was already existing indentation due to ClipNegative
Co-Authored-By: bergmeister <[email protected]>
I applied the suggestions, I have to look at the test failures though, locally it was fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this isn't quite right based on test failures
…nalyzer into FixUseConsistentIndentationBugWithSingleLinePipeline
…oop and not switch statement), simple mistake
@rjmholt @JamesWTruher @TylerLeonhardt I fixed the build, it was a simple mistake, I used a |
PR Summary
Fixes #1187 by excluding single-line pipelines to avoid reduce indentation level incorrectly. This case showed up only when there is already some indentation.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.