-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UseSingularNouns rule work on PowerShell Core #1627
Make UseSingularNouns rule work on PowerShell Core #1627
Conversation
Ah unfortunately, the fact that the package is unlicensed does block us from accepting it |
Ok, will contact the author if an MIT license or something similar can be added as it was probably not intentional by the author. Would the licence need to be on the NuGet package or just the source repo? |
@SydneyhSmith I updated it to use the |
Thanks @bergmeister that package looks good to us |
47150bf
to
9327e6f
Compare
1402a5e
to
5832be4
Compare
PR Summary
Fixes #1626
This uses the open source
Pluralize.NET
NuGet package, which uses the MIT licence. The added payload is only 20KB once.Also enhance existing code to not construct
Pluralizationservice
in foreach loop.PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.