Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix Remove empty catch block. #985

Closed
wants to merge 8 commits into from
Closed

WIP Fix Remove empty catch block. #985

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e213d45
Fix NullReferenceException when CimSuperClass is null and remove empt…
bergmeister May 5, 2018
627b62a
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister May 7, 2018
1a4991f
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister May 11, 2018
fc7fb7c
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jul 26, 2018
31b2767
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jul 27, 2018
d191ede
Merge with branch development and fix conflicts
bergmeister Oct 3, 2018
39df6b5
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jan 9, 2019
32c153a
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions Rules/UseIdenticalMandatoryParametersDSC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,21 +241,14 @@ private IDictionary<string, string> GetKeys(string fileName)
var errors = new System.Collections.ObjectModel.Collection<Exception>();
var keys = new List<string>();
List<CimClass> cimClasses = null;
try
if (!isDSCClassCacheInitialized)
{
if (!isDSCClassCacheInitialized)
{
DscClassCache.Initialize();
isDSCClassCacheInitialized = true;
}

cimClasses = dscClassImporter(mofFilepath, moduleInfo, errors);
}
catch
{
// todo log the error
DscClassCache.Initialize();
isDSCClassCacheInitialized = true;
}

cimClasses = dscClassImporter(mofFilepath, moduleInfo, errors);

var cimClass = cimClasses?.FirstOrDefault();
var cimSuperClassProperties = new HashSet<string>(
cimClass?.CimSuperClass?.CimClassProperties.Select(cimPropertyDeclaration => cimPropertyDeclaration.Name) ??
Expand Down