Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apns2.credentials: since version 2.0.0 pyJWT encode method return str #122

Merged
merged 2 commits into from
Apr 3, 2021
Merged

apns2.credentials: since version 2.0.0 pyJWT encode method return str #122

merged 2 commits into from
Apr 3, 2021

Conversation

manderj
Copy link
Contributor

@manderj manderj commented Dec 29, 2020

PyJWT latest version (2.0.0) introduce the following breaking changes:

  • encode method now return a str instead of bytes
  • python 3.5 is no longer supported

see release notes for more informations: https://github.com/jpadilla/pyjwt/releases/tag/2.0.0

@babus
Copy link

babus commented Jan 5, 2021

@manderj @Pr0Ger Could you please resolve the conflicts and do a release? Dependabot is bumping up the pyjwt to 2.0.0. So I guess that the project compatibility should be fine.

@manderj
Copy link
Contributor Author

manderj commented Jan 9, 2021

PyJWT has implemented their own typing in 2.0.0 which is not yet used by default by mypy.
Mypy is still running on old PyJWT stubs (python/typeshed#4854)
To resolve the failed checks mypy can be run directly alongside the latest package probably just by adding PyJWT in drone-pytools requirements file ? or by waiting 6 to 12 month as the discussion said

@jillro
Copy link

jillro commented Mar 30, 2021

PyJWT < 2.0.0 is in conflict with some common python packages like python-social-auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants