This repository was archived by the owner on Apr 26, 2024. It is now read-only.
When a Job can't schedule a Pod, log the Job's recent events #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the Job definition itself is fine but the Job is unable to schedule any Pods due to scheduling constraints (resources, node availability, etc), we weren't able to give users much more information than that the Pod for their flow never started. With this change, we'll go inspect any events related to that Job and include them in the logs. These events include things like scheduling constraint violations, in enough detail to help someone diagnose the issue without going back to the cluster. Closes #87
5 tasks
chrisguidry
added a commit
that referenced
this pull request
Aug 29, 2023
In #87/#88, we logged additional information from the Kubernetes Event API when a Job couldn't create a Pod. In this change, we expand that to log additional event information when a Pod can't start running. This covers cases like `ErrImagePull` or pod scheduling constraint failures that will prevent the Pod from going into a Running state. Closes #90
chrisguidry
added a commit
that referenced
this pull request
Aug 30, 2023
* Extending the Kubernetes event logging to cover Pod events In #87/#88, we logged additional information from the Kubernetes Event API when a Job couldn't create a Pod. In this change, we expand that to log additional event information when a Pod can't start running. This covers cases like `ErrImagePull` or pod scheduling constraint failures that will prevent the Pod from going into a Running state. Closes #90 * Python 3.8 type hint compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the Job definition itself is fine but the Job is unable to
schedule any Pods due to scheduling constraints (resources, node availability,
etc), we weren't able to give users much more information than that the Pod for
their flow never started. With this change, we'll go inspect any events related
to that Job and include them in the logs. These events include things like
scheduling constraint violations, in enough detail to help someone diagnose the
issue without going back to the cluster.
Closes #87
Screenshots
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.mkdocs serveview documentation locally.