Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spot instance eviction in Kubernetes Infrastructure Block #10426

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

zangell44
Copy link
Collaborator

Backports the fix for PrefectHQ/prefect-kubernetes#85 to agents + k8s infrastructure

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed

@zangell44 zangell44 added the enhancement An improvement of an existing feature label Aug 17, 2023
@zangell44 zangell44 requested a review from a team as a code owner August 17, 2023 14:41
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit a429c3f
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/64de40573e145b00087d3b11
😎 Deploy Preview https://deploy-preview-10426--prefect-docs-preview.netlify.app/api-ref/prefect/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you port the test over from PrefectHQ/prefect-kubernetes#85 also?

@zangell44 zangell44 merged commit c0a4795 into main Aug 17, 2023
@zangell44 zangell44 deleted the handle-spot-instance-eviction-2 branch August 17, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants