Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where a server can't be stopped an restarted without waiting several seconds #15729

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 16, 2024

I haven't been able to write a test to cover this change, but you can verify that it works by running prefect server start, stopping the server, and then running prefect server start again.

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Oct 16, 2024
Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #15729 will not alter performance

Comparing fix-haunted-socket (b447988) with main (b91cb6b)

Summary

✅ 2 untouched benchmarks

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

Copy link
Contributor

This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it.

@github-actions github-actions bot closed this Nov 13, 2024
@desertaxle desertaxle reopened this Jan 3, 2025
@desertaxle desertaxle marked this pull request as ready for review January 15, 2025 18:24
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this fixes it for me

@desertaxle desertaxle merged commit f906b70 into main Jan 15, 2025
48 checks passed
@desertaxle desertaxle deleted the fix-haunted-socket branch January 15, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants