-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flow run instrumentation to use RunTelemetry
class
#16233
Update flow run instrumentation to use RunTelemetry
class
#16233
Conversation
…o-standard-client
…o-standard-client
…/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
CodSpeed Performance ReportMerging #16233 will not alter performanceComparing Summary
|
…on-to-use-runtelemetry-class
…untelemetry-class' of https://github.com/PrefectHQ/prefect into jean/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
…on-to-use-runtelemetry-class
…on-to-use-runtelemetry-class
…untelemetry-class' of https://github.com/PrefectHQ/prefect into jean/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
…on-to-use-runtelemetry-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me overall, but I do have one question about if we should be propagating labels from parent task runs in addition to parent flow runs.
if parent_flow_run_context and parent_flow_run_context.flow_run: | ||
parent_labels = parent_flow_run_context.flow_run.labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be getting labels from parent task runs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a separate PR we will be rewriting which labels gets passed down since the parent span already includes label information, we don't need to include it in each of the child spans and in many cases it could overwrite 'real' data or attributes set by users.
Co-authored-by: Chris Pickett <[email protected]>
This PR refactors the OTEL instrumentation in flow run to use the
RunTelemetry
class. Other changes:test_instrumentation.py
RunTelemetry
task_engine.py
to support newer changesChecklist
<link to issue>
"mint.json
.