Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sync_compatible from prefect.variables #16349

Merged
merged 2 commits into from
Dec 11, 2024
Merged

remove sync_compatible from prefect.variables #16349

merged 2 commits into from
Dec 11, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 11, 2024 •
edited
Loading

remove sync_compatible in prefect.variables and replace it with async_dispatch

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16349 will not alter performance

Comparing remove-sync-compat-variables (da5146b) with main (3c65bca)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review December 11, 2024 22:54
@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Dec 11, 2024
desertaxle
desertaxle approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/prefect/variables.py
from prefect import flow
from prefect.variables import Variable

@flow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but why are we running these example operations when in flows? Seems unnecessary...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but agreed. will follow up in another PR

@zzstoatzz zzstoatzz merged commit e2604f9 into main Dec 11, 2024
43 checks passed
@zzstoatzz zzstoatzz deleted the remove-sync-compat-variables branch December 11, 2024 23:45
EmilRex pushed a commit that referenced this pull request Dec 13, 2024
@zzstoatzz @EmilRex
remove sync_compatible from prefect.variables (#16349)
d7d41a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzstoatzz @desertaxle