-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tutorial for clarity #16354
Merged
Merged
update tutorial for clarity #16354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discdiver
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggested edits.
451e71e
to
73498a8
Compare
good suggestions @discdiver ! updated in 73498a8 |
discdiver
approved these changes
Dec 12, 2024
zzstoatzz
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes a couple updates to the
Build a data pipeline
tutorial.submit()
/.result()
is bit more verbose and I would rather recommend using sequential.map
calls in cases where the io actually takes a while, bc in this example the second loop blocks at eachresult()
callfor
each item, instead of resolving futures concurrently like.map(list[T]).result()
. i also think its easier to read / reason aboutfor example
slower
faster
moves
rate_limit
into the task. happy to reconsider this, I was just thinking that i'd want my task runtimes to reflect time waiting for the github api to free up - but i could also see situations where you might want to avoid submission until some resource is freekeeping with the theme of the tutorial, updates the full examples to compound use of adopted features throughout the page (i.e. continue to use
retries=3
even when adding caching or rate limiting)in normal convention, defines tasks that are referenced in the
show_stars
flow before said flowuses proper type hinting