Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap OTLPLogExporter and OTLPSpanExporter in a QueueService to pull them out of the main thread #16439

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

bunchesofdonald
Copy link
Contributor

@bunchesofdonald bunchesofdonald commented Dec 18, 2024

Due to the way the OpenTelemetry OTLP Span and Log exporters work they can block execution of flows/tasks if the otel collectors they're sending data to are down. This moves their handling into QueueServices so that we unblock the main thread and flows/tasks can run normally.

Closes CLOUD-872

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #16439 will not alter performance

Comparing CLOUD-872 (aad32f9) with main (581510a)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! couple nit-ish questions about types

@bunchesofdonald bunchesofdonald merged commit 997e61d into main Dec 18, 2024
37 checks passed
@bunchesofdonald bunchesofdonald deleted the CLOUD-872 branch December 18, 2024 20:57
devinvillarosa pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants