Remove deprecated result fields and classes and associated utilities #16552
Conversation
cicdw
requested review from
aaazzam,
desertaxle,
zzstoatzz and
chrisguidry
as code owners
CodSpeed Performance ReportMerging #16552 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
looks great to me! defer to the result-father @desertaxle though for any additional compat considerations (though I can't immediately think of any inherent problems with this)
There was a problem hiding this comment.
LGTM!
I tested this PR by running a flow with tasks against a 2.x server and then upgrading to this version.
I was able to load results for the tasks run against a 2.x server after upgrade, but I couldn't load the flow result. Upon further inspection, the 2.x flow result contained all the task states which included PersistedResult instances which caused the unpickling to fail.
A flow result that only contains tasks states isn't particularly useful, so I don't think any changes are needed, but we might need to remember this if any users run into it.
This PR removes deprecated result fields and classes and associated utilities that were slated for November 2024 removal.