Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles the instrumentation case where a future is only used to wait_for #16709

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

chrisguidry
Copy link
Collaborator

@chrisguidry chrisguidry commented Jan 13, 2025

In our OpenTelemetry instrumentation, we were assuming that if we were
resolving a future before running a task, it must be a parameter. This
isn't true in the case where a future is used in wait_for, where the
context's parameter_name won't be set.

Fixes #16708

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

In our OpenTelemetry instrumentation, we were assuming that if we were
resolving a future before running a task, it must be a parameter.  This
isn't true in the case where a future is used in `wait_for`, where the
context's `parameter_name` won't be set.

Fixes #16708
@github-actions github-actions bot added the bug Something isn't working label Jan 13, 2025
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #16709 will not alter performance

Comparing no-parameter-name (3574228) with main (f9f3b7b)

Summary

✅ 2 untouched benchmarks

@chrisguidry chrisguidry merged commit 9234595 into main Jan 13, 2025
53 checks passed
@chrisguidry chrisguidry deleted the no-parameter-name branch January 13, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wait_for errors when otel extras installed
3 participants