Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Prefect Basic Auth #16735

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fixes to Prefect Basic Auth #16735

merged 4 commits into from
Jan 16, 2025
+24 −2

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 15, 2025

This PR:

  • does not re-route away from the Login screen until authentication has succeeded
  • removes the authentication gate from /api/health and /api/ready for probes to properly function

Closes #16724
Closes #16726

@github-actions github-actions bot added bug Something isn't working ui Related to the Prefect web interface labels Jan 15, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16735 will not alter performance

Comparing health-login (3c5a5ce) with main (f906b70)

Summary

✅ 2 untouched benchmarks

desertaxle
desertaxle approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@cicdw cicdw merged commit e18e438 into main Jan 16, 2025
46 checks passed
@cicdw cicdw deleted the health-login branch January 16, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ui Related to the Prefect web interface
Projects
None yet
Milestone
No milestone
2 participants
@cicdw @desertaxle