Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provisioner for Coiled push work pools #16736

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

ntabris
Copy link
Contributor

@ntabris ntabris commented Jan 15, 2025

This adds a provisioner for the Coiled push work pool, so you can do this:

prefect work-pool create "my-coiled-pool" --type coiled:push --provision-infra

It's nearly identical to the Modal push work pool provisioner, substituting coiled for modal throughout.

We'll plan to handle docs as follow up PR.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #16736 will not alter performance

Comparing ntabris:coiled-push-pool-provisioner (9d8f8e5) with main (ccbf65f)

Summary

✅ 2 untouched benchmarks

@ntabris
Copy link
Contributor Author

ntabris commented Jan 15, 2025

Here's what some of the flow and error messages look like currently (I hacked it so the install of coiled would fail)...

image

in the good case it looks like this...

image

Copy link
Contributor

@jakekaplan jakekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@cicdw cicdw merged commit 2408bee into PrefectHQ:main Jan 16, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants