Expose more Sqlalchemy settings, part 1 #16742
Open
+177
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
requested review from
discdiver,
desertaxle and
zzstoatzz
as code owners
cicdw
commented
Jan 15, 2025
| @@ -347,12 +351,6 @@ async def engine(self) -> AsyncEngine: | |||
| if self.timeout is not None: | |||
| kwargs["connect_args"] = dict(timeout=self.timeout) | |||
|
|
|||
| if self.sqlalchemy_pool_size is not None: | |||
There was a problem hiding this comment.
I added these in #16690 so this won't affect any released behavior.
CodSpeed Performance ReportMerging #16742 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes additional SQLAlchemy configuration settings through Prefect settings to enable improved testing and optimization of database setups.
Note that this PR also introduces a change to our default SQLAlchemy configuration: specifically, it adds a new default of
pool_recycle=3600where we used to not use pool recycling at all.If accepted, part 2 would be to expose settings that configure the
connect_argsspecifically (which include application name, statement caching, etc.).