Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function body import in client.find_automation #16824

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 23, 2025

In #16822, a user shared that a refactor in #16579 to address the memory footprint of the client omitted an import of UUID in the find_automation method of the client, a bug that was missed to incomplete test coverage.

This PR closes #16822 and adds the missing test. We should inspect more broadly about whether there are more holes in our test coverage of the client.

@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #16824 will not alter performance

Comparing automation-missing-import (5bd0e88) with main (7548f1b)

Summary

✅ 2 untouched benchmarks

@aaazzam aaazzam merged commit 66ab281 into main Jan 23, 2025
50 checks passed
@aaazzam aaazzam deleted the automation-missing-import branch January 23, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error due to missing uuid import in client.find_automation
2 participants