Fix prefect-dask test suite
#16920
Merged
Fix prefect-dask test suite
#16920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
changed the title
prefect-dask test suite
desertaxle
added
the
development
zzstoatzz
approved these changes
Jan 31, 2025
Comment on lines
-17
to
-47
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def event_loop(request): | ||
| """ | ||
| Redefine the event loop to support session/module-scoped fixtures; | ||
| see https://github.com/pytest-dev/pytest-asyncio/issues/68 | ||
| When running on Windows we need to use a non-default loop for subprocess support. | ||
| """ | ||
| if sys.platform == "win32": | ||
| asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy()) | ||
|
|
||
| policy = asyncio.get_event_loop_policy() | ||
|
|
||
| loop = policy.new_event_loop() | ||
|
|
||
| # configure asyncio logging to capture long running tasks | ||
| asyncio_logger = logging.getLogger("asyncio") | ||
| asyncio_logger.setLevel("WARNING") | ||
| asyncio_logger.addHandler(logging.StreamHandler()) | ||
| loop.set_debug(True) | ||
| loop.slow_callback_duration = 0.25 | ||
|
|
||
| try: | ||
| yield loop | ||
| finally: | ||
| loop.close() | ||
|
|
||
| # Workaround for failures in pytest_asyncio 0.17; | ||
| # see https://github.com/pytest-dev/pytest-asyncio/issues/257 | ||
| policy.set_event_loop(loop) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefect-dasktests are failing onmain. This PR fixes that by removing unnecessary fixtures like the scoped event loop anduse_hosted_api_server(prefect_test_harnesstakes care of that), reusing Dask clusters where possible, and updating two tests to run with only a single task runner because they aren't dependent on the task runner configuration.