Support configuring executor on the flow #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for parity between local and cloud/server runs in how you configure an executor for a flow.
5 tasks
cicdw
requested changes
Sep 17, 2020
| if executor is None: | ||
| executor = prefect.engine.get_default_executor_class()() | ||
|
|
||
| self.logger.debug("Using executor type %s", type(executor).__name__) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Split off of #3333)
This moves the
executorconfiguration to theFlowitself, rather than on the "environment". This is nice, as it improves parity betweenflow.register()andflow.run(), where the same configured executor is used. Several users have been confused in the past about whyflow.run()doesn't use the configuration in theenvironment.Another benefit here is that Flows always have to be loaded (usually unpickled), but environments are sometimes unpickled and sometimes loaded from json from cloud (on the agent). This distinction between a fully loaded environment and a half-loaded environment (that might be missing some pickled components) is confusing, removing the need for a half-loaded environment is a goal of #3333. Moving one more piece of pickled state off of environments simplifies this.
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)