Add agent registration for server users #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
requested changes
Sep 24, 2020
Co-authored-by: Chris White <[email protected]>
Co-authored-by: Chris White <[email protected]>
cicdw
approved these changes
Sep 29, 2020
| else: | ||
| self.logger.warning( | ||
| f"Unable to register agent to {self.client.api_server}. " | ||
| f"Make sure the server is running on the latest version." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables agent registration with server.
Agent persistence was added to server in PrefectHQ/server#58 and improved in PrefectHQ/server#95. Exposing agent persistence in the UI for server users is added in PrefectHQ/legacy-ui#249.
Changes
No longer bounds registration call for agents to Cloud backend. Adds route for retrieving agent configuration based on an agent config id (to be used in a later enhancement)
Importance
Improve agent experience!
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)