Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock labels #3483

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Clock labels #3483

merged 5 commits into from
Oct 13, 2020

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Oct 12, 2020

Summary

This PR exposes the ability to emit per-clock flow run labels, in addition to exposing labels on Client.create_flow_run. This will enable the ability for users to schedule Flows to run simultaneously in different places / through different agents, and moreover will allow users to create ad-hoc runs with unique label sets as needed.

Importance

This is a new feature that enables a pattern that wasn't possible before; please note this will not be available in Cloud / Server until the scheduler logic has been updated and released! We will try to have this released prior to the next release of Core 👍

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@cicdw cicdw requested review from jcrist and joshmeek as code owners October 12, 2020 21:45
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #3483 into master will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Not sure if we want to release this before this weeks core release or after, since it has blocking cloud/server changes.

@jcrist jcrist merged commit 8a24f90 into master Oct 13, 2020
@jcrist jcrist deleted the clock-labels branch October 13, 2020 17:34
@jcrist
Copy link

jcrist commented Oct 13, 2020

Discussed offline, we're going to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants