Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit exception chaining for gcp and jupyter tasks and dask execution #3721

Merged
merged 6 commits into from
Dec 1, 2020

Conversation

BluePoof
Copy link

Summary

  • Added from on each raised exception in:
    • src/prefect/environments/execution/dask.
    • src/prefect/tasks/gcp.
    • src/prefect/tasks/jupyter.

Changes

Importance

  • Improves stack trace when debugging errors by using clearer language.

Checklist

This PR:

  • adds a change file in the changes/ directory (if appropriate)

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @BluePoof! 🎉 🎉

@joshmeek
Copy link

Hey @BluePoof would you mind merging the latest from master into your branch? We just merged in a PR that fixes some of the issues we have been seeing in the CI tests!

Update Fork with changes from Upstream
@BluePoof
Copy link
Author

BluePoof commented Dec 1, 2020

@joshmeek Thanks! I've done that, though it appears there are some other things that are failing as well now

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #3721 (59dc4eb) into master (dd5f561) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@joshmeek joshmeek merged commit 5a0b6d5 into PrefectHQ:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants