Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing raise-missing-from in remaining places #4255

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

abidahmadq
Copy link

@abidahmadq abidahmadq commented Mar 16, 2021

Summary

Adds explicit exception chaining so that exception stack traces are a bit easier to comprehend in these places

  • src/prefect/engine/serializers.py
  • src/prefect/tasks/airtable/init.py
  • src/prefect/tasks/aws/batch.py
  • src/prefect/tasks/aws/client_waiter.py
  • src/prefect/tasks/azure/init.py
  • src/prefect/tasks/azureml/init.py
  • src/prefect/tasks/dbt/init.py
  • src/prefect/tasks/dropbox/init.py
  • src/prefect/tasks/gcp/bigquery.py
  • src/prefect/tasks/great_expectations/init.py
  • src/prefect/tasks/gsheets/init.py
  • src/prefect/tasks/kubernetes/init.py
  • src/prefect/tasks/postgres/init.py
  • src/prefect/tasks/redis/init.py
  • src/prefect/tasks/rss/init.py
  • src/prefect/tasks/snowflake/init.py
  • src/prefect/tasks/sql_server/init.py
  • src/prefect/tasks/templates/jinja2.py

Changes

Changes based on #3306 for remaining sub-modules.

Importance

This PR should close the #3306

Checklist

This PR:

  • adds a change file in the changes/ directory (if appropriate)

@abidahmadq abidahmadq requested a review from jcrist as a code owner March 16, 2021 18:09
@abidahmadq
Copy link
Author

abidahmadq commented Mar 16, 2021

@cicdw @jcrist What should i do about changes directory as i already had created it for last PR ? Should i create one with PR ID or just ignore it?

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as is, the existing entry can cover both. Thanks!

@jcrist jcrist merged commit de987e3 into PrefectHQ:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants