Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for mapped skips #457

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Fixes for mapped skips #457

merged 1 commit into from
Dec 27, 2018

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Dec 27, 2018

Closes #455

@cicdw
Copy link
Member Author

cicdw commented Dec 27, 2018

And the infamous #456 bites us:

tests/client/test_cloud.py::TestHeartBeats::test_flow_runner_has_a_heartbeat[mthread] Received 'aborted' signal

jlowin
jlowin approved these changes Dec 27, 2018
View reviewed changes
tests/core/test_task_map.py
assert isinstance(slist, list)
assert len(slist) == 3
assert [r.result for r in slist][1:] == [4, 5]
assert isinstance(slist[0], prefect.engine.state.Skipped)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking: slist == [Skipped, Success, Success]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup yup exactly

@cicdw cicdw merged commit 292f68a into master Dec 27, 2018
@cicdw cicdw deleted the skip-fixes branch December 27, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin approved these changes

@joshmeek joshmeek Awaiting requested review from joshmeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdw @jlowin