Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Worker pools -> work pools #8107

Merged
merged 7 commits into from
Jan 9, 2023
Merged

Rename Worker pools -> work pools #8107

merged 7 commits into from
Jan 9, 2023

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 9, 2023

This PR renames Worker Pools to work pools in all the relevant places.

NOTE: this feature is still experimental; therefore, for simplicity I chose to destructively delete all tables and references to worker pools and recreate them from scratch within the migration logic. This allowed me to maintain our naming conventions easily and clearly instead of surgically renaming things in the migration.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit e21695a
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63bc52558a722a00095bf342
😎 Deploy Preview https://deploy-preview-8107--prefect-orion.netlify.app/api-ref/orion/schemas/actions
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I just want to make sure we handle client/server cross version compatibility so that users don't get 422 errors when this released.

src/prefect/_internal/concurrency/executor.py Outdated Show resolved Hide resolved
src/prefect/client/orion.py Show resolved Hide resolved
src/prefect/orion/schemas/actions.py Show resolved Hide resolved
src/prefect/orion/schemas/actions.py Show resolved Hide resolved
src/prefect/orion/schemas/actions.py Show resolved Hide resolved
src/prefect/orion/schemas/actions.py Show resolved Hide resolved
@cicdw cicdw merged commit 4a5c11e into main Jan 9, 2023
@cicdw cicdw deleted the worker-pool-rename branch January 9, 2023 18:35
ddelange added a commit to ddelange/prefect that referenced this pull request Jan 9, 2023
…r-builds-release

* 'main' of https://github.com/ddelange/prefect: (131 commits)
  Fix docker-builds.yaml templating syntax (PrefectHQ#8114)
  Rename Worker pools -> work pools (PrefectHQ#8107)
  Build multi-arch images for commits on main (PrefectHQ#7900)
  [Issue PrefectHQ#456] Change example of `infra_override` in docs/concepts/deployment (PrefectHQ#8101)
  Bump @playwright/test from 1.29.1 to 1.29.2 in /orion-ui (PrefectHQ#8105)
  Bump @prefecthq/orion-design from 1.1.53 to 1.1.54 in /orion-ui (PrefectHQ#8104)
  Update deployment docs to include tag and idempotency key (PrefectHQ#7771)
  Add `BaseWorker` and `ProcessWorker` (PrefectHQ#7996)
  Add Peyton and Serina as global code owners (PrefectHQ#8098)
  Add release notes for 2.7.7 (PrefectHQ#8091)
  Add youtube badge (PrefectHQ#8089)
  Adds `MAX_RRULE_LENGTH` (PrefectHQ#7762)
  Limit task run cache key size (PrefectHQ#7275)
  Add --match flag to work queues documentation (PrefectHQ#7768)
  Modify disable ssl setting tests to allow any for headers and timeout (PrefectHQ#8086)
  Add test for allow_failure and quote (PrefectHQ#8055)
  Adds `experimental_field` decorator (PrefectHQ#8066)
  add docs on migrating block documents (PrefectHQ#8085)
  Add Redoc documentation for REST API reference (PrefectHQ#7503)
  Allow disabling SSL verification (PrefectHQ#7850)
  ...
ddelange added a commit to ddelange/prefect that referenced this pull request Jan 9, 2023
…refect into docker-builds-consolidation

* 'docker-builds-release' of https://github.com/ddelange/prefect: (131 commits)
  Fix docker-builds.yaml templating syntax (PrefectHQ#8114)
  Rename Worker pools -> work pools (PrefectHQ#8107)
  Build multi-arch images for commits on main (PrefectHQ#7900)
  [Issue PrefectHQ#456] Change example of `infra_override` in docs/concepts/deployment (PrefectHQ#8101)
  Bump @playwright/test from 1.29.1 to 1.29.2 in /orion-ui (PrefectHQ#8105)
  Bump @prefecthq/orion-design from 1.1.53 to 1.1.54 in /orion-ui (PrefectHQ#8104)
  Update deployment docs to include tag and idempotency key (PrefectHQ#7771)
  Add `BaseWorker` and `ProcessWorker` (PrefectHQ#7996)
  Add Peyton and Serina as global code owners (PrefectHQ#8098)
  Add release notes for 2.7.7 (PrefectHQ#8091)
  Add youtube badge (PrefectHQ#8089)
  Adds `MAX_RRULE_LENGTH` (PrefectHQ#7762)
  Limit task run cache key size (PrefectHQ#7275)
  Add --match flag to work queues documentation (PrefectHQ#7768)
  Modify disable ssl setting tests to allow any for headers and timeout (PrefectHQ#8086)
  Add test for allow_failure and quote (PrefectHQ#8055)
  Adds `experimental_field` decorator (PrefectHQ#8066)
  add docs on migrating block documents (PrefectHQ#8085)
  Add Redoc documentation for REST API reference (PrefectHQ#7503)
  Allow disabling SSL verification (PrefectHQ#7850)
  ...
masonmenges pushed a commit that referenced this pull request Jan 10, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
@zanieb zanieb mentioned this pull request Feb 3, 2023
3 tasks
zanieb pushed a commit that referenced this pull request Feb 3, 2023
zanieb pushed a commit that referenced this pull request Feb 3, 2023
zanieb pushed a commit that referenced this pull request Feb 6, 2023
zanieb pushed a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants