Add configuration to kill_infrastructure signature
#9250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
force-pushed
the
fix-missing-config-in-kill-infra
branch
from
49aaef9 to
8cfd062
Compare
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
desertaxle
changed the title
configuration to kill_infrastructure signatureconfiguration to kill_infrastructure signature
jakekaplan
approved these changes
Apr 19, 2023
This was referenced Apr 19, 2023
asmundo
pushed a commit
to asmundo/prefect
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
BaseWorkerto passconfigurationtokill_infrastructurecalls which allow worker implementations to retrieve the credentials needed to tear down created infrastructure for flow runs.This update doesn't affect the
ProcessWorkersince it doesn't rely on a configuration object, but other worker implementations in Prefect integration packages will need pin theirprefectdependency to the version where this change is implemented. Note that no other workers have implemented flow run cancellation yet.Example
Checklist
<link to issue>"fix,feature,enhancement,docs.