Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base and process worker to send flow-run related logs #9496

Merged
merged 1 commit into from
May 10, 2023
Merged

Update base and process worker to send flow-run related logs #9496

merged 1 commit into from
May 10, 2023

Conversation

bunchesofdonald
Copy link
Contributor

@bunchesofdonald bunchesofdonald commented May 9, 2023 •
edited
Loading

This updates the base and process worker to send flow-run related logs to Cloud. There's two main parts:

  1. PrefectLogAdapter now has a getChild method that will get a logger, give it an appropriate name and allow passing extra data into the logger itself.
  2. A get_flow_run_logger method on BaseWorker that gets the proper logger and sets the extra data, including worker and work pool information.

Closes #9218

Example

Screenshot 2023-05-09 at 11 20 33 AM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

@bunchesofdonald bunchesofdonald added the enhancement An improvement of an existing feature label May 9, 2023
@bunchesofdonald bunchesofdonald requested a review from a team as a code owner May 9, 2023 15:12
@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

❌ Deploy Preview for prefect-docs-preview failed.

Name Link
🔨 Latest commit a137598
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/645a6498d9161500088a4bcd

@bunchesofdonald bunchesofdonald force-pushed the worker-flow-run-logs branch from 59bf73a to a137598 Compare May 9, 2023 15:19
chrisguidry
chrisguidry approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tasty!

@bunchesofdonald bunchesofdonald merged commit 65eb8d7 into main May 10, 2023
@bunchesofdonald bunchesofdonald deleted the worker-flow-run-logs branch May 10, 2023 13:12
@WillRaphaelson WillRaphaelson changed the title Update base and process worker to send flow-run related logs to cloud Update base and process worker to send flow-run related logs May 10, 2023
@WillRaphaelson WillRaphaelson mentioned this pull request May 10, 2023
Closed
3 tasks
asmundo pushed a commit to asmundo/prefect that referenced this pull request May 11, 2023
@bunchesofdonald
Update base and process worker to send flow-run related logs to cloud (…
37a7ccc 
…PrefectHQ#9496)
@zanieb zanieb mentioned this pull request May 24, 2023
Merged
@jakekaplan jakekaplan mentioned this pull request May 24, 2023
Merged
@zanieb zanieb mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store and Display Worker Logs in Prefect UI
2 participants
@bunchesofdonald @chrisguidry