Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm template annotations #318

Closed
novotl opened this issue Nov 24, 2021 · 0 comments · Fixed by #327
Closed

Add Helm template annotations #318

novotl opened this issue Nov 24, 2021 · 0 comments · Fixed by #327
Labels
enhancement New feature or request

Comments

@novotl
Copy link
Contributor

novotl commented Nov 24, 2021

Current behavior

Prefect-server Helm chart doesn't support this currently. What exists is metadata.annotations which is not what I have in mind. I need to pass the annotations to the Pod.

Proposed behavior

Make it possible to add spec.template.metadata.annotations, the motivations behind this is:

Example

For example adding Datadog log configuration using autodiscovery (snippet from here)

apiVersion: v1
kind: Pod
# (...)
metadata:
  name: '<POD_NAME>'
  annotations:
    ad.datadoghq.com/<CONTAINER_IDENTIFIER>.logs: '[<LOG_CONFIG>]'
    # (...)
spec:
  containers:
    - name: '<CONTAINER_IDENTIFIER>'
# (...)

requires following Deployment configuration:

apiVersion: apps/v1
kind: Deployment
# (...)
spec:
  template:
    metadata:
      annotations: # <- this is currently not possible to add
        ad.datadoghq.com/<CONTAINER_IDENTIFIER>.logs: '[<LOG_CONFIG>]'
# (...)
@novotl novotl added the enhancement New feature or request label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant