Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podAnnotations to helm chart. #327

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Add podAnnotations to helm chart. #327

merged 2 commits into from
Dec 3, 2021

Conversation

novotl
Copy link
Contributor

@novotl novotl commented Dec 3, 2021 •
edited
Loading

Summary

Closes #318

Adding podAnnotations field for each deployment to allow attaching arbitrary metadata to pods.

Importance

Useful for e.g. monitoring tools. See the issue #318 description for more info

Checklist

This PR:

  • adds new tests (if appropriate)
    • running helm template helm/prefect-server -f helm/prefect-server/values.yaml locally successfully renders templates
  • adds a change file in the changes/ directory (if appropriate)

@novotl novotl marked this pull request as ready for review December 3, 2021 15:54
zanieb
zanieb approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb merged commit a9a7840 into PrefectHQ:master Dec 3, 2021
@novotl novotl deleted the pod-annotations branch December 3, 2021 16:08
@zanieb zanieb mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@cicdw cicdw Awaiting requested review from cicdw

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Helm template annotations
2 participants
@novotl @zanieb