-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support the new RunConfig pattern in core #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this won't be fully ready until we merge the Core PR, but this looks straightforward to me! I left one comment on backwards compatibility
I'm seeing errors about |
@jcrist the |
I believe this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Welcome to the server repo @jcrist :D
Adds a new
flow.run_config
field that can be used instead offlow.environment
to configure a flow run. There's likely more to do here, but so far this works with PrefectHQ/prefect#3333, see that PR for the full motivation.