Add idempotency key to flows.create_flow #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naive first implementation
Also add coverage for versions to first test
zanieb
commented
Oct 27, 2020
zanieb
commented
Oct 27, 2020
zanieb
commented
Oct 27, 2020
zanieb
changed the title
zanieb
changed the title
zanieb
changed the title
joshmeek
reviewed
Oct 27, 2020
zanieb
commented
Oct 27, 2020
cicdw
requested changes
Oct 27, 2020
Co-authored-by: Chris White <[email protected]>
And fix accidental override of flow local in that case
cicdw
requested changes
Oct 28, 2020
There was a problem hiding this comment.
Could you add one final test? I want to ensure we always update the idempotency key so that the following situation works as expected:
flow.register("Blah", idempotency_key="foo")# v1flow.register("Blah")# v2flow.register("Blah", idempotency_key="foo")<-- should actually register a new version instead of using v2
So a test that creates a flow w/ key, creates a flow without, then creates a final flow with the original key should register a new version.
Including X -> Y -> X and X -> None -> X
cicdw
approved these changes
Oct 28, 2020
| pytest.param(("foo", None, "foo"), id="same key with empty between"), | ||
| pytest.param(("foo", "bar", "foo"), id="same key with different between"), | ||
| ], | ||
| ) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional idempotency keys to the
create_flowAPI, the most recent key for a flow group is stored in thesettingsdict and is referenced when creating a flow to prevent sequential flow creation with the same key.Importance
Future work
This only works for sequential flow creation and we may want support in the future to prevent re-registrations for old flow versions. However, this would involve adding a column to the Flow table and additional complexity. We also don't really have support for old versions right now so it isn't quite necessary.
Checklist
This PR:
changes/directory (if appropriate)