-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifacts API #121
Artifacts API #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left some small comments / questions / requests
services/postgres/alembic/versions/2020-10-21T141127_add_artifact_api.py
Show resolved
Hide resolved
Co-authored-by: Chris White <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request for a different error message, otherwise this LGTM!
Co-authored-by: Chris White <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice work
Summary
Adds a new API for working with task run artifacts! This is the server side of the Artifacts API to be used in collaboration with the
artifact_api
branch on core (PrefectHQ/prefect#3581). This adds a new table to the dbtask_run_artifacts
which is a many to one relationship of artifacts to task run. Adds three new API functions and graphql mutations for creating, updating, and deleting task run artifacts.Checklist
This PR:
changes/
directory (if appropriate)Server side of the Artifacts API to be used in collaboration with the
artifact_api
branch on core (PrefectHQ/prefect#3581).This adds a new table to the db
task_run_artifacts
which is a many to one relationship of task runs to artifacts. Adds three new API functions and graphql mutations for creating, reading, and deleting task run artifacts. Comments welcome!