Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a KubernetesAgent to the Helm chart #136

Merged
merged 9 commits into from
Nov 16, 2020
Merged

Add a KubernetesAgent to the Helm chart #136

merged 9 commits into from
Nov 16, 2020

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Nov 13, 2020

Summary

Adds a KubernetesAgent deployment to the Helm chart

Importance

Most users deploying Server on K8s will want to use the K8s agent as well.

Checklist

This PR:

  • [ ] adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

@zanieb zanieb requested review from cicdw and jlowin as code owners November 13, 2020 19:19
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to remove one unnecessary env var for clarity, and a few minor questions but overall this LGTM!

helm/prefect-server/README.md Outdated Show resolved Hide resolved
helm/prefect-server/templates/agent/deployment.yaml Outdated Show resolved Hide resolved
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@cicdw cicdw merged commit 05b9838 into master Nov 16, 2020
@cicdw cicdw deleted the helm-agent branch November 16, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants