Always pull prefecthq docker images in the helm chart #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default setting from IfNotPresent to Always since we are using the 'latest' tag. This matches K8s behavior if the pull policy were null. I considered setting this to null by default and depending on the K8s default handling depending on the tag value, but it sounds like the 'latest' -> 'Always' default pull policy behavior is deprecated and I don't want to rely on it. We will likely set this back to IfNotPresent when we pin the prefectVersion for helm chart releases. However, some people prefer Always because then the image cannot accidentally be grabbed by a deployment without the proper secrets (not relevant for our images since they are public)
|
I know this is still a WIP but your reasoning makes sense to me ✅ |
cicdw
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the default setting from IfNotPresent to Always since we are
using the 'latest' tag. This matches K8s behavior if the pull policy
were null. I considered setting this to null by default and depending
on the K8s default handling depending on the tag value, but it sounds
like the 'latest' -> 'Always' default pull policy behavior is
deprecated and I don't want to rely on it.
We will likely set this back to IfNotPresent when we pin the
prefectVersion for helm chart releases. However, some people prefer
Always because then the image cannot accidentally be grabbed by a
deployment without the proper secrets (not relevant for our images
since they are public)
Important: This does introduce the issue that if a deployment is rolled,
it could pull a different version than the other deployments. This is
not ideal for some users as it introduces version compatibility issues.
I'll add a note about versioning to the README suggesting pinning
prefectVersionfor production deployments.Edit: See rendered readme section
Importance
Installations with this chart will be stuck on old versions otherwise.
Checklist
This PR:
changes/directory (if appropriate)