Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: configure strategy for deployment #165

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

joelluijmes
Copy link
Contributor

@joelluijmes joelluijmes commented Dec 17, 2020

Summary

Adds the possibility to the helm chart to configure the strategy of deployment.

Importance

Allows to configure rolling updates, for instance maybe someone (me) wants to tune the surge and unavailable parameters. Example of values.yaml

apollo:
  replicas: 3
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxSurge: 0
      maxUnavailable: 1

  affinity: 
    podAntiAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchExpressions:
          - key: app.kubernetes.io/component
            operator: In
            values:
            - apollo
        topologyKey: kubernetes.io/hostname

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks @joelluijmes ! I'm trying to decide if this is worth adding a section in the README but I feel like this is beyond the average user so it may not be worth it :)

@zanieb zanieb merged commit 29d243b into PrefectHQ:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants