Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize errors #189

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Uniformize errors #189

merged 2 commits into from
Feb 18, 2021

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 18, 2021

Summary

This PR captures all errors from GraphQL -> Hasura that have "connect" in the exception and converts them into a uniform "database query error". Other clients handle these errors specially, so we can rely on client-side behavior here instead of rolling custom retries in this code path. In looking at this it does seem we have some tech debt in error handling around here that we might want to revisit - low priority though.

cc: @mashun4ek

Importance

Helps with some fault tolerance in rare cases by relying on other clients' handling of "database query error"s.

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

@cicdw cicdw requested a review from mashun4ek February 18, 2021 03:38
@cicdw cicdw requested review from jlowin and zanieb as code owners February 18, 2021 03:38
@cicdw cicdw merged commit e533e50 into master Feb 18, 2021
@cicdw cicdw deleted the uniform-errors branch February 18, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants