Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR captures all errors from GraphQL -> Hasura that have "connect" in the exception and converts them into a uniform "database query error". Other clients handle these errors specially, so we can rely on client-side behavior here instead of rolling custom retries in this code path. In looking at this it does seem we have some tech debt in error handling around here that we might want to revisit - low priority though.
cc: @mashun4ek
Importance
Helps with some fault tolerance in rare cases by relying on other clients' handling of "database query error"s.
Checklist
This PR:
changes/
directory (if appropriate)