Add tini to graphql and apollo containers #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The healthchecks in these containers were leading to zombie processes, since there was no init process around to reap them. For some reason the other containers don't have this problem (something else must be reaping the health check processes). This PR is only half done, still needs to be added to apollo. My internet/electricity is not consistent enough right now to finish this up, would be good if someone else could.
1 task
TylerWanner
approved these changes
Feb 19, 2021
|
this is a fine solution for me |
jcrist
approved these changes
Feb 22, 2021
cicdw
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #190.
Summary
Installs
tiniand uses as an entrypoint to graphql/apollo containers to reap zombie processes.Notes for review
Uses sha256 instead of gpg for checksum verification (both are recommended checks but sha256 is significantly lighter with a 2x faster image build time)
Fails to run when build on an M1 machine with
I've added an
ARCHflag so you candocker build . --build-arg ARCH=arm64for development builds. I presume that once we use apt it'll just grab the correct binary automatically.Importance
Fixes PrefectHQ/prefect#4114
Checklist
This PR:
[ ] adds new tests (if appropriate)changes/directory (if appropriate)