Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm update rbac agent #221

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Helm update rbac agent #221

merged 3 commits into from
Mar 17, 2021

Conversation

mashun4ek
Copy link
Contributor

@mashun4ek mashun4ek commented Mar 17, 2021 •
edited
Loading

Summary

Add permissions to agent role (pods/log, services, poddisruptionbudgets). Closes #220
Dask KubeCluster rbac list.

Importance

Resolve permission errors when using DaskExecutor.

Checklist

This PR:

  • [-] adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

@mashun4ek mashun4ek marked this pull request as draft March 17, 2021 18:04
@codecov-io
Copy link

Codecov Report

Merging #221 (66e15b7) into master (236d660) will not change coverage.
The diff coverage is n/a.

@mashun4ek mashun4ek marked this pull request as ready for review March 17, 2021 19:01
cicdw
cicdw approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @mashun4ek !

@cicdw cicdw merged commit 47efa76 into master Mar 17, 2021
@cicdw cicdw deleted the helm_update_rbac_agent branch March 17, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify role so prefect-server helm chart works with dask-kubernetes.KubeConfig
3 participants
@mashun4ek @codecov-io @cicdw