Add Support for GraphQL Service timeout_keep_alive Configuration #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable but we'll want to ensure it doesn't conflict with our own uses. |
TylerWanner
approved these changes
Sep 20, 2021
|
there doesn't appear to be a way to set uvicorn keep-alive in env vars or anywhere implicitly, so I don't believe this change should be breaking to anybody |
zanieb
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for setting keep alive timeout for graphql service. Setting is added to
config.tomlwith default value of 5 seconds which matches uvicorns default setting.Importance
Was having issues with 502 errors and wanted a reliable way to set the timeout for graphql's keep alive when running in AWS ECS behind an ALB.
Checklist
This PR:
changes/directory (if appropriate)