Fix Agent Helm chart template env block

[rwilliams-exs]

Summary

The current format of the Helm templating uses indentation one step too deep, resulting in formatting errors when used. This change corrects that indentation, and changes the default value in the values.yaml file to avoid incorrect warning messages.

Importance

Allows for actually providing custom environment variables to the agent

More information

values.yaml file contents:

agent:
  enabled: true
  env:
    - name: foo
      value: bar

Pre-change

helm template helm/prefect-server --values values.yaml excerpt:

...
          - name: PREFECT__CLOUD__AGENT__AGENT_ADDRESS
            value: http://0.0.0.0:8080
            - name: foo
              value: bar
...

Accompanying error message:

Error: YAML parse error on prefect-server/templates/agent/deployment.yaml: error converting YAML to JSON: yaml: line 61: did not find expected key

Post change

helm template helm/prefect-server --values values.yaml excerpt:

...
          - name: PREFECT__CLOUD__AGENT__AGENT_ADDRESS
            value: http://0.0.0.0:8080
          - name: foo
            value: bar
...

Error message resolved

[zanieb]

Hi @rwilliams-exs! Thanks for contributing. This looks great. Can you add a changelog entry per https://github.com/PrefectHQ/server/tree/master/changes?

[rwilliams-exs]

Hi @madkinsz, I have added the changelog entry as requested - please let me know if there's anything else required and I'll be happy to oblige

[zanieb]

Thanks!

[jamedge]

Hi, when can we expect a helm chart release with this fix? Thanks!