Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service role annotations #314

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

rwilliams-exs
Copy link
Contributor

Summary

Allows for setting custom annotations on the Service Role

Importance

Enables usage of features such as EKS RBAC

Checklist

This PR:

  • adds a change file in the changes/ directory (if appropriate)

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor ask for a nice user-facing changelog entry

changes/pr314.yaml Outdated Show resolved Hide resolved
Co-authored-by: Michael Adkins <[email protected]>
@zanieb zanieb merged commit e884510 into PrefectHQ:master Nov 17, 2021
@rwilliams-exs rwilliams-exs deleted the add_service_role_annotations branch November 17, 2021 18:49
@zanieb zanieb mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants